Skip to content

HBASE-29531 Addendum fix missing charset in RS Status page#7597

Merged
taklwu merged 1 commit intoapache:branch-2.6from
PDavid:HBASE-29531-rs-missing-charset-branch-2.6
Jan 7, 2026
Merged

HBASE-29531 Addendum fix missing charset in RS Status page#7597
taklwu merged 1 commit intoapache:branch-2.6from
PDavid:HBASE-29531-rs-missing-charset-branch-2.6

Conversation

@PDavid
Copy link
Contributor

@PDavid PDavid commented Jan 6, 2026

Made sure that the Content-Type HTTP header includes the UTF-8 charset when the RegionServer status web UI page is returned so that it is consistent with Master Status web UI page.

@PDavid PDavid self-assigned this Jan 6, 2026
@PDavid
Copy link
Contributor Author

PDavid commented Jan 6, 2026 •
edited
Loading

This problem was uncovered in #7568 (comment).
This seems to only be an issue on branch-2 and branch-2.6 (not a problem on master or branch-3).

@PDavid PDavid marked this pull request as ready for review January 6, 2026 12:52
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@PDavid
HBASE-29531 Addendum fix missing charset in RS Status page
4a663ac 
Made sure that the Content-Type HTTP header includes the UTF-8 charset when the RegionServer status web UI page is returned so that it is consistent with Master Status web UI page.
@PDavid PDavid force-pushed the HBASE-29531-rs-missing-charset-branch-2.6 branch from 21aae05 to 4a663ac Compare January 7, 2026 07:58
@PDavid PDavid requested a review from taklwu January 7, 2026 07:58
@PDavid PDavid mentioned this pull request Jan 7, 2026
Merged
@Apache-HBase
Copy link

Apache-HBase commented Jan 7, 2026

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 52s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ branch-2.6 Compile Tests _
+1 💚 mvninstall 4m 8s branch-2.6 passed
+1 💚 compile 3m 7s branch-2.6 passed
+1 💚 checkstyle 0m 40s branch-2.6 passed
+1 💚 spotbugs 1m 40s branch-2.6 passed
+1 💚 spotless 0m 51s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 9s the patch passed
+1 💚 compile 3m 7s the patch passed
+1 💚 javac 3m 7s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 39s the patch passed
+1 💚 spotbugs 1m 46s the patch passed
+1 💚 hadoopcheck 17m 23s Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.1.
+1 💚 spotless 0m 46s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 11s The patch does not generate ASF License warnings.
40m 23s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7597/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #7597
Optional Tests dupname asflicense javac codespell detsecrets spotless spotbugs checkstyle compile hadoopcheck hbaseanti
uname Linux 7f63718bfc2c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.6 / 4a663ac
Default Java Eclipse Adoptium-11.0.23+9
Max. process+thread count 78 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7597/2/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Jan 7, 2026

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 49s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.6 Compile Tests _
+1 💚 mvninstall 3m 34s branch-2.6 passed
+1 💚 compile 0m 58s branch-2.6 passed
+1 💚 javadoc 0m 29s branch-2.6 passed
+1 💚 shadedjars 6m 27s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 4s the patch passed
+1 💚 compile 0m 58s the patch passed
+1 💚 javac 0m 58s the patch passed
+1 💚 javadoc 0m 27s the patch passed
+1 💚 shadedjars 6m 28s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌ unit 214m 19s /patch-unit-hbase-server.txt hbase-server in the patch failed.
242m 49s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7597/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #7597
Optional Tests javac javadoc unit compile shadedjars
uname Linux 4cb7dcab14c6 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.6 / 4a663ac
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7597/2/testReport/
Max. process+thread count 3294 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7597/2/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Jan 7, 2026

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 46s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.6 Compile Tests _
+1 💚 mvninstall 2m 27s branch-2.6 passed
+1 💚 compile 0m 42s branch-2.6 passed
+1 💚 javadoc 0m 24s branch-2.6 passed
+1 💚 shadedjars 5m 28s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 2m 24s the patch passed
+1 💚 compile 0m 43s the patch passed
+1 💚 javac 0m 43s the patch passed
+1 💚 javadoc 0m 24s the patch passed
+1 💚 shadedjars 5m 28s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 221m 24s hbase-server in the patch passed.
245m 19s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7597/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #7597
Optional Tests javac javadoc unit compile shadedjars
uname Linux c4833df2357e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.6 / 4a663ac
Default Java Temurin-1.8.0_412-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7597/2/testReport/
Max. process+thread count 3151 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7597/2/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Jan 7, 2026

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 39s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.6 Compile Tests _
+1 💚 mvninstall 2m 47s branch-2.6 passed
+1 💚 compile 0m 37s branch-2.6 passed
+1 💚 javadoc 0m 22s branch-2.6 passed
+1 💚 shadedjars 4m 43s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 2m 11s the patch passed
+1 💚 compile 0m 36s the patch passed
+1 💚 javac 0m 36s the patch passed
+1 💚 javadoc 0m 19s the patch passed
+1 💚 shadedjars 4m 41s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌ unit 224m 8s /patch-unit-hbase-server.txt hbase-server in the patch failed.
245m 55s
Subsystem Report/Notes
Docker ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7597/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #7597
Optional Tests javac javadoc unit compile shadedjars
uname Linux 871f11700f10 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.6 / 4a663ac
Default Java Eclipse Adoptium-11.0.23+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7597/2/testReport/
Max. process+thread count 3468 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7597/2/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@PDavid
Copy link
Contributor Author

PDavid commented Jan 7, 2026

Some tests failed: TestAcidGuaranteesWith*, TestPrefetchPersistence. I think they are unrelated.

@PDavid PDavid added the backport This PR is a back port of some issue or issues already committed to master label Jan 7, 2026
taklwu
taklwu approved these changes Jan 7, 2026
View reviewed changes
Copy link
Contributor

@taklwu taklwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taklwu taklwu merged commit b57fb2c into apache:branch-2.6 Jan 7, 2026
1 check failed
@PDavid PDavid deleted the HBASE-29531-rs-missing-charset-branch-2.6 branch January 8, 2026 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taklwu taklwu taklwu approved these changes

Assignees

@PDavid PDavid

Labels

backport This PR is a back port of some issue or issues already committed to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PDavid @Apache-HBase @taklwu